[perl] Update Strawberry Perl to 5.38.0.1 and switch to GitHub. #33854
Conversation
BillyONeal
added
info:internal
|
Thank you thank you thank you @shawnlaffan ! https://github.com/StrawberryPerl/Perl-Dist-Strawberry/releases/tag/SP_5380_5361 |
| set(tool_subdirectory ${program_version}) | ||
| set(paths_to_search ${DOWNLOADS}/tools/perl/${tool_subdirectory}/perl/bin) | ||
| set(brew_package_name "perl") | ||
| set(apt_package_name "perl") | ||
| set(download_urls | ||
| "https://strawberryperl.com/download/${program_version}/strawberry-perl-${program_version}-32bit.zip" | ||
| "https://github.com/StrawberryPerl/Perl-Dist-Strawberry/releases/download/SP_5380_5361/strawberry-perl-5.38.0.1-64bit-portable.zip" |
There was a problem hiding this comment.
Does this need extra guards, and extra announcements, due to requiring 64 bit hosts?
Should 32 bit hosts continue to use the old version?
There was a problem hiding this comment.
32 bit builds do not currently exist but might yet be done. This is being tracked under StrawberryPerl/Perl-Dist-Strawberry#96
There was a problem hiding this comment.
We already require 64 bit in a bunch of other places
There was a problem hiding this comment.
My concern is the UX when users are on x86 windows hosts. If they don't even get to this point, fine. Otherwise, it should be handled in a way that doesn't create too many new issue reports. (Using the old download might be a good mitigation.)
BillyONeal
changed the title
Resolves #28288